Ticket #54 (closed defect: fixed)

Opened 1 year ago

Last modified 4 months ago

XMPP messages not acknowledged

Reported by: jmacloue Assigned to: kuhlmann
Priority: major Milestone: fixed-in-0.7.1
Component: Jabber Version: 0.7
Keywords: Cc:

Description

GoogleTalk? messages sent to contacts using CLIMM and GMail web client are not acknowledged properly but get delivered with (almost) no problems. As a consequence they are not shown in "last" command output but "h" command shows them correctly. 

climm> msg jmacloue31@gmail.com Test
climm> last
climm> h jmacloue31@gmail.com
2009-05-18 13:02 [  16] -> Test
climm>

P.S. Don't know why but contacts using Miranda IM are not affected by this issue.

Change History

05/18/09 12:05:32 changed by jmacloue

Forgot to mention - I'm using CLIMM r2814 and iksemel r10 - both from SVN.

05/18/09 19:42:11 changed by kuhlmann

  • version changed from svn#head to 0.7.

05/20/09 23:41:27 changed by jmacloue

  • component changed from OSCAR to Jabber.
  • summary changed from GoogleTalk messages not acknowledged to XMPP messages not acknowledged.

More info on the case:

  • Miranda users are affected as well (my bad, didn't check it thoroughly enough)
  • Notifications (composing/not composing) from Miranda and Pidgin arrive correctly and are displayed in 'last' but without any details: 
    00:23:14 jeff@home.macloue.com logged on (online) [Pidgin 2.5.1].
00:23:26 jeff@home.macloue.com <composing> 
00:23:30 jeff@home.macloue.com <composing> 
00:23:30 jeff@home.macloue.com <no composing>
...
climm> last
00:23:26 jeff@home.macloue.com->  
00:23:30 jeff@home.macloue.com->  
00:23:30 jeff@home.macloue.com->  
00:23:30 jeff@home.macloue.com<-  Hello!
  • Installed jabberd2 to try the things out in a "friendly" environment - the same bug applies to CLIMM at both ends: messages are not acknowledged and missing from 'last' output.

07/20/09 13:06:19 changed by jmacloue

  • status changed from new to closed.
  • resolution set to worksforme.

Fix seems to be trivial: 

Index: xmpp_base.c
===================================================================
--- xmpp_base.c (revision 2822)
+++ xmpp_base.c (working copy)
@@ -722,7 +722,7 @@
    
 static void XmppHandleXEP22c (Server *serv, iksid *from, char *tof, char 
*id, char *type)
 {  
-    iks *msg  = iks_make_msg (IKS_TYPE_NONE, tof, NULL);
+    iks *msg  = iks_make_msg (IKS_TYPE_NONE, from->partial, NULL);
     iks_insert_attrib (msg, "id", s_sprintf ("ack-%s-%x", serv->xmpp_stamp, ++serv->xmpp_sequence));
     iks *x = iks_insert (msg, "x");
     iks_insert_attrib (x, "xmlns", "jabber:x:event");

Took me some time to realize that acknowledgement is sent to me instead of the other guy. :)

07/20/09 14:20:47 changed by LeSpocky

  • status changed from closed to reopened.
  • resolution deleted.

Don't close tickets where the patch is not applied to the source and commited to the repo.

08/16/09 18:25:17 changed by kuhlmann

  • milestone set to fixed-in-next.

Fixed in r2827.

03/20/10 18:20:52 changed by kuhlmann-admin

  • status changed from reopened to closed.
  • resolution set to fixed.
  • milestone changed from fixed-in-next to fixed-in-0.7.1.